Skip to content

feat: added ARP Table informatio and corresponding testcase - #259

Open
FriendlyButFire wants to merge 1 commit into
prometheus-community:mainfrom
FriendlyButFire:master
Open

feat: added ARP Table informatio and corresponding testcase#259
FriendlyButFire wants to merge 1 commit into
prometheus-community:mainfrom
FriendlyButFire:master

Conversation

@FriendlyButFire

Copy link
Copy Markdown

Files that have been added:
./pkg/probe/system_arp.go
./pkg/probe/system_arp_test.go
./pkg/probe/testdata/arp.jsonnet

Files that have been changed:
./pkg/probe/probe.go
./README.md

Tested on FortiGate KVM with FortiOS Version v7.0.5

@bluecmd bluecmd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This metric will have to be disabled by default if you really really want it in the current state. The metric dimensions are extremely large (any IP * any MAC * any interface).

Are you sure this is what you want? The total amount of MACs per interface isn't enough?

Comment thread README.md
* _System/Fortimanager/Status_
* `fortigate_fortimanager_connection_status`
* `fortigate_fortimanager_registration_status`
* `fortigate_ippool_total_items`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste error?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, sorry, don't really know if to remove I have to recommit

@FriendlyButFire

Copy link
Copy Markdown
Author

This metric will have to be disabled by default if you really really want it in the current state. The metric dimensions are extremely large (any IP * any MAC * any interface).

Are you sure this is what you want? The total amount of MACs per interface isn't enough?

Being disabled by default is fine for me, that's the use case I'm aiming for, I just wanted to share the implementation of it to everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants